Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newlines in JSON output #4262

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Fix newlines in JSON output #4262

merged 2 commits into from
Jun 23, 2020

Commits on Jun 19, 2020

  1. Fix newlines in JSON output 

    This changes the JSON output to be more consistent about where newlines are included. Previously it only included them between lines in a multiline diff. That meant single line changes were treated a bit weirdly. This changes it to append a newline to every line.

When feeding the results into `arc lint` this behaves correctly. I have only done limited testing though, in particular there's a possibility it might not work with files with `\r\n` endings (though that would have been the case before too).

Fixes rust-lang#4259
    @Timmmm
    Timmmm authored and Tim Hutt committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9de1139 View commit details
    Browse the repository at this point in the history

  2. Update tests

    Tim Hutt committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9b74b29 View commit details
    Browse the repository at this point in the history