Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate const keyword on parameters #4294

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

topecongiro
Copy link
Contributor

Kudos to @ayazhafiz for updating the rustc frontend; now, the rustc AST has enough information to calculate the correct span of generic parameters.

Close #4263.

Copy link
Contributor

@ayazhafiz ayazhafiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@topecongiro topecongiro merged commit cccf7fe into rust-lang:master Jul 3, 2020
@topecongiro topecongiro deleted the issue-4263 branch July 3, 2020 02:11
@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

backported in #4673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Const generic parameter following a comment gets corrupted
4 participants