fix: between span derivation on cast exprs #4536
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Nov 19, 2020
| @@ -236,10 +236,10 @@ pub(crate) fn format_expr( | |||
| /* Retrieving the comments before and after cast */ | |||
| let prefix_span = mk_sp( | |||
| subexpr.span.hi(), | |||
| context.snippet_provider.span_before(expr.span, "as"), | |||
| context.snippet_provider.span_before_last(expr.span, "as") - BytePos(1), | |||
There was a problem hiding this comment.
Think there's a separate bug in this util function that only backs the position off by one, but feels like it should be the length of the needle. Our needle is the as keyword, so moving it back by one to avoid snagging the a in the keyword
calebcartwright
changed the title
ytmimi
added
1x-backport:pending
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4534