stabilize disable_all_formatting
#5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize that this was previously considered and then declined in favor of stabilizing
ignore. However, it's been more than two years since that was last discussed, andignoreremains unstabilized with some outstanding issues that need to be resolved first.I completely agree with the strategic target of having
ignorein place which will obviate the need for this option, but for years now projects that have opted to not utilize rustfmt haven't had a viable way to prevent unintentional and undesired formatting changes from contributors, and this has been an unnecessary source of friction given the presence of this option and its readiness for stabilization.As such, I'm going to stabilize this with disclaimers about deferring to
ignorewhen possible and that this will likely be soft deprecated (warning emitted, automatically mapped toignore) whenever we actually manage to getignorestabilized.