refactor: encapsulate all parsing touchpoints in a single mod #5143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ytmimi - best reviewed commit by commit
This is the type of thing I was referring to the other day. The blast radius of rustc_parse touch points was supposed to be contained within our
syntux
module (now renamed toparse
), but particularly around macro handling that encapsulation had been broken/never fully encapsulated.This just pulls everything into one place almost exclusively via copy/paste and renames (delta between lines added and removed is just due to the greater number of smaller files, resulting in some extra lines for imports).
However, the
asm!
changes aren't pulled in yet because i forget to update the visibility on the asm mod in the compiler 😢