Add test to validate the config loading rules #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tempfile` crate can help us set up temporary directories used for testing, and the `tmp_env` crate can help us set temporary environment variables when testing.
Configs are loaded in the following order: 1. Load configs from the `--config-path` option 2. Travers the directory hierarchy looking for a config file 3. Check the user's `HOME` directory for a config file 4. Check the user's config directory for a config file
use the `serial_test` crate to explicity allow rustfmt integration tests to run in parallel or in series. Becuase the `test_load_config_logic` test updates the working directory while it's running other tests should't be allowed to run at the same time as it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5471
Test that configs are loaded in the following order:
--config-pathoptionHOMEdirectory for a config fileProbably best to review this PR 1 commit at a time.