doc: remove installing from source #5786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add "run from source" in contributing.md
xxchan
commented
Jun 19, 2023
Comment on lines
-74
to
-79
| ## Installation | ||
|
|
||
| ```sh | ||
| rustup component add rustfmt | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This is already covered above.
Comment on lines
-74
to
-78
| ## Installation | ||
|
|
||
| ```sh | ||
| rustup component add rustfmt | ||
| ``` |
There was a problem hiding this comment.
I think it's probably worth leaving this section in still given the different rustup profiles. Thoughts?
There was a problem hiding this comment.
This is already covered in "Quick start".
There was a problem hiding this comment.
ah, dueling review comments sorry. it is somewhat duplicative isn't it, think i'm fine removing it for now then. if we find folks are really struggling without a specific "install" section then we can add it back/do something different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add "run from source" in contributing.md
@calebcartwright PTAL