handle skip_macro_invocations from config file #5817
Merged
+29
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5816
We need to keep the
FromStr
impl forMacroSelector
(e.g. to support command line config args), so seems reasonable to just have the serde deserializer use that impl too.I'm not sure whether there's a better/simpler approach to achieve that (e.g. an item-level serde attribute), but adding our own
Deserialize
impl seems trivial enough