Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nfc_normalize_idents flag #6072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Feb 13, 2024

Addresses #6058 @ytmimi

@ytmimi
Copy link
Contributor

ytmimi commented Feb 13, 2024

@Jules-Bertholet when you have a moment can you remove the fix for #6069 from this PR and open a separate PR that independently addresses that issue.

@Jules-Bertholet
Copy link
Contributor Author

The test for the nfc_normalize_idents relies on the #6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

@ytmimi
Copy link
Contributor

ytmimi commented Feb 13, 2024

The test for the nfc_normalize_idents relies on the #6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

Yeah, I'd rather split them out. The fix for #6069 will be easier to land, and then we can keep iterating on this new configuration.

@ytmimi ytmimi mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants