Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itertools bump to 0.12 #6093

Merged
merged 1 commit into from
Apr 25, 2024
Merged

itertools bump to 0.12 #6093

merged 1 commit into from
Apr 25, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 25, 2024

@klensy klensy mentioned this pull request Feb 25, 2024
Merged
@ytmimi
Copy link
Contributor

ytmimi commented Feb 26, 2024

@klensy thanks for the PR. I took a really quick look at the changelog (thanks for the link), and I'll review it more thoroughly when I've got some time, but I wanted to ask you if you think there are any breaking changes in the 0.12 release that you think would impact rustfmt?

@klensy
Copy link
Contributor Author

klensy commented Feb 26, 2024

Don't think so: mentioned breaking changes in changelog should give compile errors if unfixed.

@ytmimi
Copy link
Contributor

ytmimi commented Feb 26, 2024

Don't think so: mentioned breaking changes in changelog should give compile errors if unfixed.

Okay. I'm mostly wondering if there are any changes in behavior that wouldn't be caught at compile time.

Nadrieril added a commit to Nadrieril/rust that referenced this pull request Mar 9, 2024
@Nadrieril
Rollup merge of rust-lang#121584 - klensy:itertools-up, r=Mark-Simula…
bc3bc2b 
…crum

bump itertools to 0.12

still depend on 0.11 (temporary dupes version):
* <del>clippy</del>, rust-lang/rust-clippy#12346
* rustfmt, sigh, rust-lang/rustfmt#6093

https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md

removed unused `derive_more` dep from `rustc_middle`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@rust-timer
Unrolled build for rust-lang#121584
c50800f 
Rollup merge of rust-lang#121584 - klensy:itertools-up, r=Mark-Simulacrum

bump itertools to 0.12

still depend on 0.11 (temporary dupes version):
* <del>clippy</del>, rust-lang/rust-clippy#12346
* rustfmt, sigh, rust-lang/rustfmt#6093

https://github.com/rust-itertools/itertools/blob/v0.12.1/CHANGELOG.md

removed unused `derive_more` dep from `rustc_middle`
ytmimi
ytmimi approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to reviewing the v0.12 changelog, and I agree that there don't seem to be any breaking changes that would impact rustfmt.

@ytmimi ytmimi merged commit 4b1596f into rust-lang:master Apr 25, 2024
27 checks passed
@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Apr 25, 2024
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klensy @ytmimi @rustbot