Check exit status of git commands spawned by build script #6266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git commands
git rev-parse HEAD
andgit log -1 --date=short --pretty=format:%cd
in rustfmt's build script might fail with "fatal: not a git repository (or any of the parent directories): .git" if rustfmt is being built from a source tarball rather than a git repository. That message is written by git to stderr, and nothing is written to stdout.Previously, rustfmt's build script would take that empty stdout and treat it like valid commit info, unlike what it does when
git
cannot be spawned in the first place, and contradicting this comment about the build script's intended behavior in the case of there not being a git repository:rustfmt/build.rs
Lines 24 to 25 in 17c5869
Before this PR:
rustfmt 1.7.1-nightly ( )
After first commit:
rustfmt 1.7.1-
After second commit:
rustfmt 1.7.1