Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterators2 doesn't compile before step 2 #359

Closed
sapir opened this issue Apr 20, 2020 · 2 comments · Fixed by #648
Closed

iterators2 doesn't compile before step 2 #359

sapir opened this issue Apr 20, 2020 · 2 comments · Fixed by #648
Labels
A-exercises Area: Exercises C-bug Category: Bug P-medium Priority: Medium

Comments

@sapir
Copy link

sapir commented Apr 20, 2020

The instructions say to first make the first 2 tests pass, but the last 2 tests have compilation errors. Of course, it can easily be fixed by commenting them out. Still, maybe it would be nicer if Step 1 could be completed without having to do that?

@sapir
Copy link
Author

sapir commented Apr 20, 2020

I see iterators3 has the last parts commented out. This has the disadvantage that after completing the first part, rustlings watch thinks I've completed the exercise.

@lynoure
Copy link

lynoure commented Jun 18, 2020

I was briefly sidetracked by that as well. There have been other exercises where the next in series builds on the previous solution. Maybe this could be done with the iterators2 as well, by splitting it into 3 different parts. Alternatively, even just having the commenting out mentioned in the hint would be an improvement.

@shadows-withal shadows-withal added A-exercises Area: Exercises C-bug Category: Bug P-medium Priority: Medium labels Jul 23, 2020
apogeeoak added a commit to apogeeoak/rustlings that referenced this issue Feb 12, 2021
ingrachen pushed a commit to ingrachen/rustlings that referenced this issue May 2, 2021
liangminhua pushed a commit to liangminhua/rustlings that referenced this issue Jul 10, 2021
noiffion pushed a commit to noiffion/rustlings that referenced this issue Aug 20, 2021
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this issue Dec 28, 2021
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exercises Area: Exercises C-bug Category: Bug P-medium Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants