Convert exercises with assertions to tests #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo8it
changed the title
|
@shadows-withal waiting for your feedback. No pressure! Just to let you know that is not marked as draft because I will edit it before a review. It is just to not be merged directly :) |
shadows-withal
approved these changes
Sep 4, 2023
|
that being said, I think it's fine to keep |
|
Alright, the PR would be ready for merging then after your review, right? :D |
|
Oh yeah sure! Let me do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted all exercises having assertions to test mode.
I am not really sure about all implications of this conversion. Please review it first. You might think that some of them should have both a main function and a test.
Should the function names be changed?
mainis not a good test function name. I can use other names if you want.