Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending UI #2077

Closed
wants to merge 1 commit into from
Closed

Add pending UI #2077

wants to merge 1 commit into from

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 8, 2024

This is a POC of this suggestion. It's a little hacky, but as far as I understand it will be removed again once the issue with rust-analyzer is fixed. I think removing it is a good idea, because rust-analyzer is working fine for me and the pending UI is only shown for a very short amount of time.

Also, I added the pending UI at the very bottom, because if rust-analyzer isn't running at all the UI becomes very janky if any of the other text changes or moves.

@mo8it
Copy link
Contributor

mo8it commented Aug 8, 2024

Thanks, but there is no need to keep the a pending state. I solved by only adding this:

writeln!(
self.writer,
"\nChecking the exercise `{}`. Please wait…",
self.app_state.current_exercise().name,
)?;

I will also keep it even after the Rust-Analyzer issue is resolved. It gives the user instant feedback which can be relevant on older PCs or with exercises with a long runtime.

@mo8it mo8it closed this Aug 8, 2024
@senekor
Copy link
Contributor Author

senekor commented Aug 8, 2024

Much better 👍

@senekor senekor deleted the remo/lwomxnlppxrl branch August 8, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants