-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional test to meet exercise rules #284
Conversation
@@ -70,4 +70,10 @@ mod tests { | |||
assert_eq!(p.name, "Mark"); | |||
assert_eq!(p.age, 20); | |||
} | |||
#[test] | |||
fn test_bad_age() { | |||
let p = Person::from("Mark,twenty"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment like in the tests above would be nice here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ae07cec
to
bc22ec3
Compare
@bors: r+ |
📌 Commit bc22ec3 has been approved by |
☀️ Test successful - checks-travis |
Adds additional test to meet exercise rules This PR adds an additional test to meet this exercise [rule](https://github.com/rust-lang/rustlings/blob/master/exercises/conversions/from_into.rs#L33).
Adds additional test to meet exercise rules This PR adds an additional test to meet this exercise [rule](https://github.com/rust-lang/rustlings/blob/master/exercises/conversions/from_into.rs#L33).
This PR adds an additional test to meet this exercise rule.