Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional test to meet exercise rules #284

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

sl4m
Copy link
Contributor

@sl4m sl4m commented Mar 10, 2020

This PR adds an additional test to meet this exercise rule.

@@ -70,4 +70,10 @@ mod tests {
assert_eq!(p.name, "Mark");
assert_eq!(p.age, 20);
}
#[test]
fn test_bad_age() {
let p = Person::from("Mark,twenty");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment like in the tests above would be nice here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sl4m sl4m force-pushed the update-from-into-ex branch from ae07cec to bc22ec3 Compare March 11, 2020 14:58
@shadows-withal
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 11, 2020

📌 Commit bc22ec3 has been approved by fmoko

@bors
Copy link
Contributor

bors commented Mar 11, 2020

⌛ Testing commit bc22ec3 with merge 700b236...

@bors
Copy link
Contributor

bors commented Mar 11, 2020

☀️ Test successful - checks-travis
Approved by: fmoko
Pushing 700b236 to master...

@bors bors merged commit 700b236 into rust-lang:master Mar 11, 2020
@sl4m sl4m deleted the update-from-into-ex branch March 11, 2020 15:44
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Adds additional test to meet exercise rules

This PR adds an additional test to meet this exercise [rule](https://github.com/rust-lang/rustlings/blob/master/exercises/conversions/from_into.rs#L33).
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Adds additional test to meet exercise rules

This PR adds an additional test to meet this exercise [rule](https://github.com/rust-lang/rustlings/blob/master/exercises/conversions/from_into.rs#L33).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants