Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structs1): Adjust wording #573

Merged
merged 3 commits into from
Nov 8, 2020
Merged

fix(structs1): Adjust wording #573

merged 3 commits into from
Nov 8, 2020

Conversation

13r0ck
Copy link
Contributor

@13r0ck 13r0ck commented Oct 28, 2020

The hint for structs1 improperly stated that there are 2 types of structs. Updated to clarify there are 3.

I changed the link to the page related to the exercise directly, though the one previous link is not necessarily wrong as it is one page before the link I prefer.

The hint for structs1 improperly stated that there are 2 types of structs. Updated to clarify there are 3.

I changing the link to the page related to the exercise directly, though the one previous link is not necessarily wrong as it is one page before the link I prefer.
@13r0ck
Copy link
Contributor Author

13r0ck commented Oct 28, 2020

If I am wrong then https://doc.rust-lang.org/rust-by-example/custom_types/structs.html needs to be updated, as It states there are 3.

Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of small nits

info.toml Outdated Show resolved Hide resolved
info.toml Outdated Show resolved Hide resolved
13r0ck and others added 2 commits November 7, 2020 08:20
I agree this is more clear

Co-authored-by: fmoko <mokou@posteo.de>
Typo

Co-authored-by: fmoko <mokou@posteo.de>
@shadows-withal shadows-withal changed the title Fix structs1 fix(structs1): Adjust wording Nov 8, 2020
@shadows-withal shadows-withal merged commit 9334783 into rust-lang:main Nov 8, 2020
JuniousY pushed a commit to JuniousY/rustlings that referenced this pull request Jan 28, 2021
Co-authored-by: fmoko <mokou@posteo.de>
mccormickt pushed a commit to mccormickt/rustlings that referenced this pull request Mar 10, 2021
Co-authored-by: fmoko <mokou@posteo.de>
noiffion pushed a commit to noiffion/rustlings that referenced this pull request Aug 20, 2021
Co-authored-by: fmoko <mokou@posteo.de>
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
Co-authored-by: fmoko <mokou@posteo.de>
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Co-authored-by: fmoko <mokou@posteo.de>
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Co-authored-by: fmoko <mokou@posteo.de>
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
Co-authored-by: fmoko <mokou@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants