-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(structs1): Adjust wording #573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hint for structs1 improperly stated that there are 2 types of structs. Updated to clarify there are 3. I changing the link to the page related to the exercise directly, though the one previous link is not necessarily wrong as it is one page before the link I prefer.
If I am wrong then https://doc.rust-lang.org/rust-by-example/custom_types/structs.html needs to be updated, as It states there are 3. |
TianyiShi2001
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of small nits
I agree this is more clear Co-authored-by: fmoko <mokou@posteo.de>
Typo Co-authored-by: fmoko <mokou@posteo.de>
JuniousY
pushed a commit
to JuniousY/rustlings
that referenced
this pull request
Jan 28, 2021
Co-authored-by: fmoko <mokou@posteo.de>
mccormickt
pushed a commit
to mccormickt/rustlings
that referenced
this pull request
Mar 10, 2021
Co-authored-by: fmoko <mokou@posteo.de>
noiffion
pushed a commit
to noiffion/rustlings
that referenced
this pull request
Aug 20, 2021
Co-authored-by: fmoko <mokou@posteo.de>
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
Co-authored-by: fmoko <mokou@posteo.de>
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Co-authored-by: fmoko <mokou@posteo.de>
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Co-authored-by: fmoko <mokou@posteo.de>
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
Co-authored-by: fmoko <mokou@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint for structs1 improperly stated that there are 2 types of structs. Updated to clarify there are 3.
I changed the link to the page related to the exercise directly, though the one previous link is not necessarily wrong as it is one page before the link I prefer.