fix: improve function argument type in functions3.rs #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakolefluk
changed the title
flakolefluk
changed the title
shadows-withal
approved these changes
Apr 4, 2021
|
Thanks! @all-contributors add @flakolefluk for content |
|
@fmoko I've put up a pull request to add @flakolefluk! 🎉 |
barder60
pushed a commit
to barder60/rustlings
that referenced
this pull request
Apr 13, 2021
tcatonet
pushed a commit
to tcatonet/rustlings
that referenced
this pull request
Apr 13, 2021
LAymeric
pushed a commit
to LAymeric/rustlings
that referenced
this pull request
Apr 13, 2021
wh5a
pushed a commit
to wh5a/rustlings-solutions
that referenced
this pull request
Apr 17, 2021
* upstream/main: Rename lichi to lychee in the fruit example docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] fix: use trait objects for from_str fix: use trait objects for try_from_into docs: update .all-contributorsrc [skip ci] docs: update README.md [skip ci] fix(functions3): improve function argument type (rust-lang#687) doc: Update collections exercises instruction to match the standard naming fix(collections): Naming exercises for vectors and hashmap
ingrachen
pushed a commit
to ingrachen/rustlings
that referenced
this pull request
May 2, 2021
lsagna
pushed a commit
to lsagna/rustlings
that referenced
this pull request
May 10, 2021
liangminhua
pushed a commit
to liangminhua/rustlings
that referenced
this pull request
Jul 10, 2021
noiffion
pushed a commit
to noiffion/rustlings
that referenced
this pull request
Aug 20, 2021
bugaolengdeyuxiaoer
pushed a commit
to bugaolengdeyuxiaoer/rustlings
that referenced
this pull request
Dec 28, 2021
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Spacebody
pushed a commit
to Spacebody/my-rustlings
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Going through the exercise functions3.rs, it feels like using u32 instead of i32 could be an improvement. Even though passing a negative number won't make the compiler complaint and the loop will exit immediately, it feels that it lacks of intention (to the eyes of someone who's learning like me). I hope this small change makes sense.