Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rustup's self update by default if the CI environment variable is detected #3824

Closed
rami3l opened this issue May 13, 2024 · 3 comments · Fixed by #3907
Closed

Disable Rustup's self update by default if the CI environment variable is detected #3824

rami3l opened this issue May 13, 2024 · 3 comments · Fixed by #3907

Comments

@rami3l
Copy link
Member

rami3l commented May 13, 2024

Proposed as an alternative to #3821, mitigates #3709:

Rustup could default to not auto update if the CI environment variable is present. This is simple both to implement and explain to users.

Originally posted by @ChrisDenton in #3821 (comment)

Notes

  • The relevant user guide section should be adjusted accordingly.
  • This change might cause Rustup's own tests to fail, so removing CI from the environment variables is probably required before actually running those tests.
@LuXts
Copy link

LuXts commented May 29, 2024

Claimed.

@rami3l
Copy link
Member Author

rami3l commented May 29, 2024

@LuXts Thanks a lot :)

@rami3l
Copy link
Member Author

rami3l commented Jun 25, 2024

As there has been about a month of inactivity, plus there's #3907 already, I think it's time to unassign you. Sorry @LuXts!

@djc djc closed this as completed in #3907 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants