Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable automatic self updates in CI environments #3907

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Disable automatic self updates in CI environments #3907

merged 1 commit into from
Jun 25, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 25, 2024 •
edited
Loading

Fixes #2886, fixes #3824.

@djc djc requested a review from rami3l June 25, 2024 08:38
djc
djc commented Jun 25, 2024
View reviewed changes
src/config.rs Show resolved Hide resolved
@djc djc marked this pull request as ready for review June 25, 2024 08:39
@rami3l rami3l mentioned this pull request Jun 25, 2024
Closed
rami3l
rami3l approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, as long as the CI is doing well...

rami3l
rami3l reviewed Jun 25, 2024
View reviewed changes
src/config.rs Outdated Show resolved Hide resolved
@djc djc added this pull request to the merge queue Jun 25, 2024
@smoelius
Copy link
Contributor

FWIW, I think this is a really good idea. Thank you!

Merged via the queue into master with commit d4bbf6c Jun 25, 2024
27 checks passed
@djc djc deleted the ci-no-self-update branch June 25, 2024 10:24
@rami3l rami3l mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rami3l rami3l rami3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@djc @smoelius @rami3l