Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zsh install support #1013

Merged
merged 4 commits into from
Apr 1, 2017
Merged

zsh install support #1013

merged 4 commits into from
Apr 1, 2017

Conversation

polonez
Copy link
Contributor

@polonez polonez commented Mar 26, 2017

  • add path to .zprofile
  • add a test for zsh

@Diggsey
Copy link
Contributor

Diggsey commented Mar 26, 2017

Thanks for the PR, we should definitely start improving the experience for more different shells.

However, I think we should always add to .profile regardless, and also add to shell-specific files if we think that shell will be used. For zsh, a good heuristic might be whether ~/.zprofile already exists, or whether SHELL is set to zsh as you are checking here.

@brson
Copy link
Contributor

brson commented Mar 27, 2017

I like @Diggsey's suggestions here. In general, I think the surest way we're going to be able to reliably set PATH is by pessimistically configuring in multiple places on Unix.

@polonez
Copy link
Contributor Author

polonez commented Mar 27, 2017

I'll update soon, thanks.

@Diggsey
Copy link
Contributor

Diggsey commented Apr 1, 2017

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit 9a9abe1 has been approved by Diggsey

@bors
Copy link
Contributor

bors commented Apr 1, 2017

⌛ Testing commit 9a9abe1 with merge 68848c9...

bors added a commit that referenced this pull request Apr 1, 2017
@bors
Auto merge of #1013 - polonez:feature/zsh-support, r=Diggsey
68848c9 
zsh install support

- add path to .zprofile
- add a test for zsh
@bors
Copy link
Contributor

bors commented Apr 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Diggsey
Pushing 68848c9 to master...

@bors bors merged commit 9a9abe1 into rust-lang:master Apr 1, 2017
@nickhs nickhs mentioned this pull request Apr 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@polonez @Diggsey @brson @bors