Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x86_64-linux-android target #1086

Merged
merged 5 commits into from
May 17, 2017
Merged

Add x86_64-linux-android target #1086

merged 5 commits into from
May 17, 2017

Conversation

malbarbo
Copy link
Contributor

No description provided.

@malbarbo
Copy link
Contributor Author

The travis rust update is necessary because x86_64-linux-android target was recently added. The nightly channel is not necessary, using the beta channel would be enough.

@brson
Copy link
Contributor

brson commented May 5, 2017

This looks great @malbarbo. Since this updates the pinned toolchain for travis, will you also update the same in appveyor.yml?

@malbarbo
Copy link
Contributor Author

malbarbo commented May 6, 2017

@brson I update the toolchain in appveyor.yml.

@brson
Copy link
Contributor

brson commented May 8, 2017

@bors r+ thanks @malbarbo!

@bors
Copy link
Contributor

bors commented May 8, 2017

📌 Commit 4501d91 has been approved by brson

@bors
Copy link
Contributor

bors commented May 8, 2017

☔ The latest upstream changes (presumably #1101) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor

brson commented May 9, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2017

📌 Commit d9e680c has been approved by brson

@malbarbo
Copy link
Contributor Author

malbarbo commented May 9, 2017

@brson Added a missing case in rustup-dist. Sorry for missing that.

@Diggsey
Copy link
Contributor

Diggsey commented May 17, 2017

@bors r=brson

@bors
Copy link
Contributor

bors commented May 17, 2017

📌 Commit a983f32 has been approved by brson

@bors
Copy link
Contributor

bors commented May 17, 2017

⌛ Testing commit a983f32 with merge 156678f...

bors added a commit that referenced this pull request May 17, 2017
@bors
Auto merge of #1086 - malbarbo:android-x86_64, r=brson
156678f 
Add x86_64-linux-android target
@bors bors mentioned this pull request May 17, 2017
Merged
@bors
Copy link
Contributor

bors commented May 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 156678f to master...

@bors bors merged commit a983f32 into rust-lang:master May 17, 2017
@bors bors mentioned this pull request May 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malbarbo @brson @bors @Diggsey