#820 Supress confusing NotADirectory error and show override missing #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! It all looks good. @bors r+ |
|
📌 Commit 1f27bbf has been approved by |
bors
added a commit
that referenced
this pull request
May 21, 2017
#820 Supress confusing NotADirectory error and show override missing This is my attempt at tackling issue #820. Hopefully I interpreted the original request correctly and this is what you were looking for. It is my first time dealing with error_chain, so not 100% sure I did it right. Any suggestions you might have to improve the submission would be great. Thanks!
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 1f27bbf has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at tackling issue #820.
Hopefully I interpreted the original request correctly and this is what you were looking for.
It is my first time dealing with error_chain, so not 100% sure I did it right.
Any suggestions you might have to improve the submission would be great.
Thanks!