Added a link to all installers to the homepage #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Mar 8, 2018
www/index.html
Outdated
| @@ -26,22 +26,25 @@ | |||
| <div id="platform-instructions-unix" class="instructions" style="display: none;"> | |||
| <p>Run the following in your terminal, then follow the onscreen instructions.</p> | |||
| <pre>curl https://sh.rustup.rs -sSf | sh</pre> | |||
| <p class="other-platforms-help">You appear to be running Unix. Click <a class="default-platform-button" href="#">here</a> to see the installer for all supported platforms.</p> | |||
There was a problem hiding this comment.
Could we rephrase these links to avoid the 'click here' anti-pattern, e.g., make the link text "view all supported installers" or something like that
There was a problem hiding this comment.
What about : "You appear to be running Unix. If not, [display all supported installers]."
|
ping @withoutboats any comments on this? |
|
ping @alexcrichton and @withoutboats - any thoughts? I'm inclined to merge this with my review comment addressed. |
|
Sounds good to me! |
|
Hey @thibaultdelor, any chance you could update the PR with that change? Thanks! |
|
Sure will do today
…On Sun., 27 May 2018, 11:04 pm Diggory Blake, ***@***.***> wrote:
Hey @thibaultdelor <https://github.com/thibaultdelor>, any chance you
could update the PR with that change? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAqWJc6NqAEB6avXFF0s6rt-_qzrk9ajks5t2qRngaJpZM4ShlVT>
.
|
|
Here you go. I have also slightly reduced the font so it looks on one line in windows. It was looking weird otherwise. |
|
r? @Diggsey |
|
Thanks, looks great! |
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Mar 9, 2024
Added a link to all installers to the homepage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #1253
I have just resolved conflict of #1270 and adapted to the new index page.
Here is how it looks:
