Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version number #1432

Merged
merged 6 commits into from
Jul 7, 2018
Merged

Bump version number #1432

merged 6 commits into from
Jul 7, 2018

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Jun 9, 2018

No description provided.

@Diggsey Diggsey requested a review from alexcrichton June 9, 2018 23:08
@alexcrichton
Copy link
Member

This should be fine to merge when ready, after merging to master you'll want to push the stable branch, and when that's done I can do the rigamarole of publishing the release

@bors
Copy link
Contributor

bors commented Jul 7, 2018

☔ The latest upstream changes (presumably #1446) made this pull request unmergeable. Please resolve the merge conflicts.

@Diggsey
Copy link
Contributor Author

Diggsey commented Jul 7, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jul 7, 2018

📌 Commit 4bbd51e has been approved by Diggsey

@bors
Copy link
Contributor

bors commented Jul 7, 2018

⌛ Testing commit 4bbd51e with merge d4958de...

bors added a commit that referenced this pull request Jul 7, 2018
@bors
Auto merge of #1432 - rust-lang-nursery:db-bump-version, r=Diggsey
d4958de 
Bump version number
@Diggsey
Copy link
Contributor Author

Diggsey commented Jul 7, 2018

@alexcrichton we currently have two failing bors tests (powerpc64le and netbsd) both of which appear to be caused by rustc issues. Is that going to be a problem?

@mati865
Copy link
Contributor

mati865 commented Jul 7, 2018 •
edited
Loading

powerpc64le issue is basically: rust-lang/rust#50499
It will be fixed in next stable (1.28).

NetBSD is more tricky, setvbuf should be available in system libc. Maybe bot is too old?

@bors
Copy link
Contributor

bors commented Jul 7, 2018

💔 Test failed - status-travis

@Diggsey Diggsey merged commit 573895a into master Jul 7, 2018
@Diggsey Diggsey deleted the db-bump-version branch July 7, 2018 16:40
@Diggsey
Copy link
Contributor Author

Diggsey commented Jul 7, 2018

@alexcrichton I've merged and pushed to stable anyway

@alexcrichton
Copy link
Member

Ok! It's probably fine to drop some of those platforms

@alexcrichton
Copy link
Member

Ok published now!

@Diggsey
Copy link
Contributor Author

Diggsey commented Jul 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diggsey @alexcrichton @bors @mati865