Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An additional indication for input after the first question #1435

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

wwkeyboard
Copy link
Contributor

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
> 

To help indicate to the user that they are expected to enter a number and press enter. It's probably my fault for trying to install rust first thing in the morning, but I sat at this screen for 2 or 3 sips of coffee waiting for it to proceed before realizing I needed to press return. Maybe this caret will help someone else avoid my delay! 😄

@Diggsey
Copy link
Contributor

Diggsey commented Jun 15, 2018

Hehe, nice carrot 😛

Thanks for the PR, looks like there are a few tests you'll need to update though!

@wwkeyboard
Copy link
Contributor Author

😲 I'll fix those after work today!

@wwkeyboard wwkeyboard force-pushed the caret-for-first-question branch from 4b4225e to 67717d3 Compare June 16, 2018 00:30
@wwkeyboard
Copy link
Contributor Author

I've also removed the extra space after the caret because lots of editors strip trailing whitespace when you save a file and I didn't want anyone to get caught up by inadvertently causing those tests to fail.

@Diggsey Diggsey merged commit bb6f65f into rust-lang:master Jun 16, 2018
@Diggsey
Copy link
Contributor

Diggsey commented Jun 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants