Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symlinks when installing #1504

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Conversation

tromey
Copy link
Contributor

@tromey tromey commented Sep 14, 2018

The lldb-preview component includes symlinks. Currently, rustup
changes these to be regular files while installing. This then causes
the resulting lldb to load liblldb twice, which causes a crash at
startup, because command line options are registered twice. This
changes rustup to preserve symlinks when installing.

The lldb-preview component includes symlinks.  Currently, rustup
changes these to be regular files while installing.  This then causes
the resulting lldb to load liblldb twice, which causes a crash at
startup, because command line options are registered twice.  This
changes rustup to preserve symlinks when installing.
@tromey
Copy link
Contributor Author

tromey commented Sep 14, 2018

I wasn't sure if I should base this on stable perhaps?

@tromey
Copy link
Contributor Author

tromey commented Sep 17, 2018

@nrc would you mind reviewing this or forwarding it to someone else to review? Fixing this is the next (hopefully final) step in getting lldb to work via rustup.

@nrc nrc merged commit e262938 into rust-lang:master Sep 18, 2018
@nrc
Copy link
Member

nrc commented Sep 18, 2018

LGTM!

@tromey tromey deleted the preserve-symlinks branch September 18, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants