-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering of component list
by available, required, and installed
#1635
Conversation
Hi @lazorgator, Thanks for your contribution to Rustup. Could you please confirm if this is just a wishlist feature from you, or is there an issue already filed which you think you're addressing with this commit? If there's the latter then I'd really like to see the commit mention it. Also, thank you for including a test for the feature, but it'd also be helpful if you could write a small section for If you aren't comfortable writing that then let me know, I wouldn't block the feature purely on that, but it'd be super-nice to have. |
Hi there @kinnison , I actually noticed this wasn't implemented from hacking on rustup for the past couple days and implemented it as a feature off-hand. If that's not okay due to concerns about feature creep, it's fine if it's not merged. I can work on the README entry for it, most certainly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight wording change to point the user at --toolchain
and I think this will be golden.
42b417e
to
9c4de11
Compare
@kinnison Added mention of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
r? @dwijnand
☔ The latest upstream changes (presumably #1643) made this pull request unmergeable. Please resolve the merge conflicts. |
9c4de11
to
26ed8d8
Compare
Messed up the PR. README changes overwritten. I'll close this now in favor of a new PR on top of the 2018 Edition changes :< |
Allows filtering of
rustup component list
command.Example output: