Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reqwest to 0.9.14, enable socks feature #1746

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

seanmonstar
Copy link
Contributor

Fixes #1712
Fixes #1736

(It'd be cool if we had some proxy tests so that we could add some more, but we don't...)

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this includes a Cargo.lock change, I'll want to review it more carefully when I have access to my personal laptop, but on the face of it, the change to Cargo.toml looks fine.

Amusingly I was gearing up to ping you this morning about these very issues to see how the reqwest work was going, so this is an awesome thing to wake up to. Thank you.

(Approval is subject to my checking Cargo.lock later today)

@kinnison
Copy link
Contributor

I have confirmed the Cargo.lock update is good.

@kinnison kinnison merged commit 41ac62c into rust-lang:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants