Enable shellcheck and fold Travis log #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
force-pushed
the
shellcheck
branch
8 times, most recently
from
084e195 to
151d82d
Compare
kinnison
reviewed
Apr 21, 2019
|
I'm pretty much prepared to merge this, except I think I'd like it if the depth bit was removed rather than suggesting we'd be happy to unremove it once the bug is fixed. I'd much prefer to always have full git history for the CI in case we add further diagnostics. |
|
I removed the depth flag. Now Travis will clone full depth when building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1760
r? @kinnison