-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listing of installed targets #1808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thanks for this patch, it looks pretty OK but it needs a test and possibly some README updates to complete the work.
Do you think you can see how to write a test for this?
Hey! Thank you for the review. I believe I need to add tests to Something similar to: Do you think that I am heading to the right direction? |
I think I managed to implement all the required tests. I am not sure about README updates. Could you point me the place to make documentation changes @kinnison ? I've got a question about the number of commits: Should I leave as is or squash them into one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
The added tests look excellent, thank you very much!
I'm happy with the commits as they are, or you could squash the three test commits into one.
Either way, I'll look to merge this in soon, unless anyone else objects.
Thanks again,
D.
I squashed test commits into one 🎉 I hope this feature will be useful for others as well. Thanks for the review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The squash looks clean
This feature adds the ability to list installed
targets
only.I'm playing with cross-compilation a lot and I need a way to list only the installed
targets
.