Bug 1870 - UI edition #1885
Merged
Bug 1870 - UI edition #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sender can be parameterised with a type parameter allowing write-once handlers that can handle any Notification type within their enum hierarchy as long as From is present, unlike the receiver (because the receiver is passed as a parameter to the function that will be doing the callback.) Less adapters, less closures, less headaches when introducing UI interactions to currently UI-interactionless codepaths.
kinnison
suggested changes
Jun 3, 2019
There was a problem hiding this comment.
Fundamentally looks good.
There's a formatting bogon and I think one missed spot where you need to qualify the _ argument in a closure, but otherwise I think this is likely good to go.
My only concern is how much extra spew it produces. Is it possible for you to include a comment on the PR showing the increased verbosity, or are you stuck not able to trigger the issue yourself?
Once you've fixed the CI bogons, I'll approve.
When we spin retrying a rename, show a UI notification. Rather raw but much better than silently doing nothing for an extended period.
kinnison
approved these changes
Jun 3, 2019
|
Indeed I have not encountered it
…On Mon, 3 Jun 2019, 22:54 Daniel Silverstone, ***@***.***> wrote:
Merged #1885 <#1885> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1885>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADZ7XQE57EJXLZCWTDF3BDPYTZ7VANCNFSM4HSDT5EA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1870's fix didn't show users what was going on and could stall for up to 30 seconds while waiting. This will show info: messages when that happens; perhaps a lot of them, but better on balance I think than absolutely nothing. Further refinement is of course possible but I think this is the minimum needed to make more releases sensible to do.