-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the cargo and rustup home paths #1914
Conversation
CI builds are failing due to some windows-only hard link error. Doesn't seem related to this change. All errors look like this:
|
src/cli/self_update.rs
Outdated
@@ -74,6 +74,15 @@ Cargo's bin directory, located at: | |||
|
|||
{cargo_home_bin} | |||
|
|||
This can be modified with the CARGO_HOME envorinment variable. | |||
|
|||
Rustup metadata and toolchains will be installed the Rustup home |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar error here - "will be installed the" -> "will be installed into the"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Also fixed misspelling of environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me other than the minor grammar error. @kinnison is there anything we need to do copyright wise - DCO, just accept it, etc?
If you're okay with the content then I'd like to see the commits squashed, there's no need for a "grammar fix" or "spelling fix" commit. Then it can merge. |
Let me know if there's anything else needed. |
During interactive installation, the user will see the cargo home
directory as well as the rustup home directory. They will also see the
environment variables which control these paths.
Fixes #1907