Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message more specific when the shell profile cannot be updated. #1925

Merged

Conversation

C-Saunders
Copy link
Contributor

@C-Saunders C-Saunders commented Jul 1, 2019

This is intended to close #292.

I went with the error_chain approach @kinnison suggested (thank you, by the way!), but am certainly open to changing that, as well as anything else (e.g. should tests be added for the other supported rc files?).

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

@kinnison kinnison merged commit 8fab4b4 into rust-lang:master Jul 1, 2019
@C-Saunders C-Saunders deleted the shell_profile_amend_failure_msg branch July 1, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail better if .profile file can't be modified
3 participants