Remove GPG signature support #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change: the gpg config settings, variables, and related cli commands are all removed. Fixes: rust-lang#3250 by removing our GPG support. - the foundation's new security engineer Walter Pearce is working on a new system, not based around GPG, for validation of distributions - we don't rely on the signatures today - these warnings are not errors by default - sustained ignored, unfixable signature errors will teach folk to ignore them, which is harmful to everyone - we could do streaming unpacking (with some changes) if we trust the transport rather than the current monolithic signature validation, which could improve performance Downloads still have a checksum which is verified.
Rustin170506
approved these changes
Mar 21, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change: the gpg config settings, variables, and
related cli commands are all removed.
Fixes: #3250 by removing our GPG support.
new system, not based around GPG, for validation of distributions
by default
ignore them, which is harmful to everyone
transport rather than the current monolithic signature validation,
which could improve performance
Downloads still have a checksum which is verified.