Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SockAddr::init to try_init #328

Merged

Conversation

Thomasdezeeuw
Copy link
Collaborator

To match the function signature, which returns a result. Also allows to
add an init function that never fails, if ever needed.

Updates #231.

To match the function signature, which returns a result. Also allows to
add an init function that never fails, if ever needed.
Copy link
Collaborator

@chansuke chansuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Thomasdezeeuw Thomasdezeeuw merged commit 057f6c2 into rust-lang:master Aug 14, 2022
@Thomasdezeeuw Thomasdezeeuw deleted the issue_231_sockaddr_try_init branch August 14, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants