Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on DragonFly: IP_RECVTOS and join_leave_ssm_v4() disabled #342

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

kworr
Copy link
Contributor

@kworr kworr commented Aug 28, 2022

Well, it makes build and tests clean. Not sure if I'm doing it right though.

Also IP_RECVTOS support issue do prevent socket2 v0.4.6 building.

@kworr
Copy link
Contributor Author

kworr commented Aug 28, 2022

Actual problem with ssm:

thread 'join_leave_ssm_v4' panicked at 'Joined SSM: Os { code: 42, kind: Uncategorized, message: "Protocol not available" }', tests/socket.rs:1246:53

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also enable the the test:

fn join_leave_ssm_v4() {
.

@kworr
Copy link
Contributor Author

kworr commented Aug 31, 2022

Can you also enable the the test:

fn join_leave_ssm_v4() {

.

I'm bit sure I got this right, if I enable this test while SSM functions are disabled I'll get this:

   Compiling socket2 v0.4.6 (/home/arcade/work/socket2.other)
error[E0599]: no method named `join_ssm_v4` found for struct `Socket` in the current scope
    --> tests/socket.rs:1246:21
     |
1246 |     let () = socket.join_ssm_v4(&s, &g, &interface).expect("Joined SSM");
     |                     ^^^^^^^^^^^ method not found in `Socket`

error[E0599]: no method named `leave_ssm_v4` found for struct `Socket` in the current scope
    --> tests/socket.rs:1247:21
     |
1247 |     let () = socket.leave_ssm_v4(&s, &g, &interface).expect("Left SSM");
     |                     ^^^^^^^^^^^^ method not found in `Socket`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `socket2` due to 2 previous errors

Though I'm testing on 0.4.6, can't build trunk as of right now.

@Thomasdezeeuw Thomasdezeeuw merged commit 4c56bb9 into rust-lang:master Aug 31, 2022
@Thomasdezeeuw
Copy link
Collaborator

@kworr sorry in my haste I read the cfg wrong, it has a not around I didn't read. Thanks for the changes.

If you want I can backport this into v0.4.x.

@kworr
Copy link
Contributor Author

kworr commented Aug 31, 2022

Yes, please, if this can be backported to 0.4.x that would be nice.

@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants