372: Implement Eq and Hash for socket2::SockAddr

Cargo.toml

@@ -48,3 +48,7 @@ features = [
 [features]
 # Enable all API, even ones not available on all OSs.
 all = []
+
+[dev-dependencies]
+quickcheck = "1.0.3"
+quickcheck_macros = "1.0.0"

src/lib.rs

@@ -59,6 +59,12 @@
 // Disallow warnings in examples.
 #![doc(test(attr(deny(warnings))))]
 
+#[cfg(test)]
+extern crate quickcheck;
+#[cfg(test)]
+#[macro_use(quickcheck)]
+extern crate quickcheck_macros;
+
 use std::fmt;
 use std::mem::MaybeUninit;
 use std::net::SocketAddr;

src/sockaddr.rs

@@ -341,6 +341,13 @@ unsafe fn any_as_u8_slice<T: Sized>(p: &T, size: usize) -> &[u8] {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use quickcheck::{self, Arbitrary};
+
+    impl Arbitrary for SockAddr {
+        fn arbitrary(g: &mut quickcheck::Gen) -> Self {
+            SockAddr::from(std::net::SocketAddr::arbitrary(g))
+        }
+    }
 
     #[test]
     fn ipv4() {
@@ -491,6 +498,40 @@ mod tests {
         assert!(b != a0);
     }
 
+    #[allow(clippy::eq_op)] // allow x == x
+    #[quickcheck]
+    fn reflexive_eq(x: SockAddr) -> bool {
+        x == x
+    }
+
+    #[quickcheck]
+    fn symmetric_eq(x: SockAddr, y: SockAddr) -> bool {
+        (x == y) == (y == x)
+    }
+
+    #[quickcheck]
+    fn transitive_eq(x: SockAddr, y: SockAddr, z: SockAddr) -> bool {
+        if x == y && y == z {
+            x == z
+        } else {
+            true
+        }
+    }
+
+    #[quickcheck]
+    fn consistent_eq(x: SockAddr, y: SockAddr) -> bool {
+        (x == y) == (x == y)
+    }
+
+    #[quickcheck]
+    fn hash(x: SockAddr, y: SockAddr) -> bool {
+        if x == y {
+            calculate_hash(&x) == calculate_hash(&y)
+        } else {
+            true
+        }
+    }
+
     fn test_hash(a0: SockAddr, a1: SockAddr, b: SockAddr) {
         assert!(calculate_hash(&a0) == calculate_hash(&a0));
         assert!(calculate_hash(&a0) == calculate_hash(&a1));