Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Windows #409

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Conversation

Thomasdezeeuw
Copy link
Collaborator

This was cherry-pick picked from the v0.5 branch, but never compiled
properly due changed made to v0.5. Combine that with a broken CI, which
we didn't know about, and you've got a broken v0.4.8 release.

Fixes #408

This was cherry-pick picked from the v0.5 branch, but never compiled
properly due changed made to v0.5. Combine that with a broken CI, which
we didn't know about, and you've got a broken v0.4.8 release.
@Thomasdezeeuw Thomasdezeeuw requested a review from Darksonn March 3, 2023 10:50
Cargo hack uses a newer Rust version than our MSRV, so manually
installing it is becoming a pain.
@Thomasdezeeuw Thomasdezeeuw merged commit 25613f5 into rust-lang:v0.4.x Mar 3, 2023
@Thomasdezeeuw Thomasdezeeuw deleted the issue_408 branch March 3, 2023 14:48
@abonander
Copy link
Contributor

Thanks @Thomasdezeeuw! Sorry for the compilation error, I didn't have the time to test it on a Windows PC before it was merged. I noticed the v0.4.x branch only runs tests on FreeBSD, though.

@Thomasdezeeuw
Copy link
Collaborator Author

No problem. Yes GitHub Actions weren't run, only our Circle CI, thus reporting a green CI without actually doing all of the checks. The first commit in this pr first that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants