Add SockAddr::set_length #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't be the first item in the documentation.
|
Fixing the Cirrus CI in #430. |
Merged
Darksonn
approved these changes
Apr 11, 2023
Comment on lines
+162
to
+164
| pub unsafe fn set_length(&mut self, length: socklen_t) { | ||
| self.len = length; | ||
| } |
There was a problem hiding this comment.
This puts a libc type in your public API. Did you intend to do that?
There was a problem hiding this comment.
We already have that in various other places, e.g. the len function also returns socklen_t. So, it's not ideal and I'm aware of the complexities that then come with updating libc and windows-sys, but they're type definitions (not e.g. structs) should they should remain compatible between dependency updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And two cleanups.