-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for original_dst for windows #529
feat: add support for original_dst for windows #529
Conversation
8976de5
to
227ae86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that at least Linux has SO_ORIGINAL_DST
and IP6T_SO_ORIGINAL_DST
as well, can we add it for it as well?
@Thomasdezeeuw it's already added in the sys/unix.rs file: Line 2420 in 3a93893
|
Ah, in that case it should be moved to the |
Ok yeah I had that thought but wanted to confirm. Will make the change! |
5efec85
to
7a46f91
Compare
@Thomasdezeeuw any clue what's going on with the FreeBSD CI? From what I can tell, it looks like it's failing due to the test runners not support ipv6 |
7a46f91
to
d75c86d
Compare
I opened #534 to address the FreeBSD failures |
@Thomasdezeeuw gentle ping for review |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
272b5d2
to
039f205
Compare
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
039f205
to
128d5dc
Compare
Thanks @keithmattix |
I noticed there wasn't support for original dst in Windows, so I added it. Also add windows gnu target to allow cross compiling