Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stabilization documentation #32

Merged
merged 17 commits into from
May 27, 2022
Merged

Update stabilization documentation #32

merged 17 commits into from
May 27, 2022

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented Mar 3, 2022

I updated this to include a section on partial stabilizations, though the example bit is currently incomplete because the PR I'm using as the basis for the example has not yet been opened. I've also updated the guide to stabilization to be based on the equivalent section that currently lives in the rustc-dev-guide1. Once we land this I plan to update the rustc-dev-guide to remove their duplicate section and instead cross reference the std-dev-guide.

Footnotes

  1. https://rustc-dev-guide.rust-lang.org/stability.html#stabilizing-a-library-feature

@yaahc yaahc force-pushed the stabilization-update branch from 3db14c8 to fb852e9 Compare March 3, 2022 22:55
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm just slightly worried about making this process seem more daunting than it is in practice, especially for very small features. For very small features we currently don't expect experience reports or some proof that it's well-tested.

src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
src/feature-lifecycle/stabilization.md Outdated Show resolved Hide resolved
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@yaahc yaahc force-pushed the stabilization-update branch 2 times, most recently from 222bee8 to e03b68b Compare May 27, 2022 20:21
@yaahc yaahc force-pushed the stabilization-update branch from e03b68b to 31712ea Compare May 27, 2022 20:28
@yaahc yaahc merged commit 22b26d5 into master May 27, 2022
@yaahc yaahc deleted the stabilization-update branch May 27, 2022 20:54
github-actions bot pushed a commit that referenced this pull request May 27, 2022
RalfJung added a commit to RalfJung/rust that referenced this pull request Jul 3, 2022
…pdate, r=JohnTitor

Link to stabilization section in std-dev-guide for library tracking issue template

This shouldn't land until rust-lang/std-dev-guide#32 is merged.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 3, 2022
…pdate, r=JohnTitor

Link to stabilization section in std-dev-guide for library tracking issue template

This shouldn't land until rust-lang/std-dev-guide#32 is merged.
RalfJung added a commit to RalfJung/rust that referenced this pull request Jul 3, 2022
…pdate, r=JohnTitor

Link to stabilization section in std-dev-guide for library tracking issue template

This shouldn't land until rust-lang/std-dev-guide#32 is merged.
RalfJung added a commit to RalfJung/rust that referenced this pull request Jul 3, 2022
…pdate, r=JohnTitor

Link to stabilization section in std-dev-guide for library tracking issue template

This shouldn't land until rust-lang/std-dev-guide#32 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants