Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ambiguous glob re-exports caused by vcvtq_s32_f32 #1446

Closed
bvanjoi opened this issue Jul 27, 2023 · 4 comments · Fixed by #1449
Closed

ambiguous glob re-exports caused by vcvtq_s32_f32 #1446

bvanjoi opened this issue Jul 27, 2023 · 4 comments · Fixed by #1449

Comments

@bvanjoi
Copy link

bvanjoi commented Jul 27, 2023

There are two vcvtq_s32_f32 functions defined in core_arch::arm::neon and core_arch::arm_shared::neno::generated and they are re-exported at the following locations:

This issue was found at rust-lang/rust#113099 (comment)

@bvanjoi
Copy link
Author

bvanjoi commented Jul 27, 2023

ambiguous-glob-reexports is currently set as a warning level lint. The error due to the #![deny(warnings)] attribute, maybe we can easily solve this problem by add #![allow(ambiguous_glob_reexports)]

@lu-zero
Copy link
Contributor

lu-zero commented Jul 27, 2023

why is it happening only for vcvtq_s32_f32 ? or it is just the first of many?

@bvanjoi
Copy link
Author

bvanjoi commented Jul 27, 2023

only for vcvtq_s32_f32 and vcvtq_u32_f32.

@lu-zero
Copy link
Contributor

lu-zero commented Jul 27, 2023

the neon.rs has use crate::core_arch::arm_shared::neon::*;

the hand crafted impl could be removed.

Amanieu added a commit to Amanieu/stdarch that referenced this issue Jul 30, 2023
Amanieu added a commit to Amanieu/stdarch that referenced this issue Jul 30, 2023
Amanieu added a commit that referenced this issue Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants