-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an env override to std_detect #804
Comments
Shall this env variable be read at run-time, or at build time ? Either way, I think enabling this should be put behind a cargo feature that's disabled by default. |
I think it should be during runtime, so you dont have to recompile the world. |
run-time
Not sure how to name the feature. (and how to advertise it) |
|
I'm sold on it, now, which crate should expose it? |
Also: should we make the cpu feature checks macro behave like log? |
Maybe
There is an RFC that allows something like that: rust-lang/rfcs#2725 but I'm not sure if that's what you mean. |
It is exactly what I meant. I'll start sending the refactoring patches and the initial impl soon. |
Sometimes it can be useful to disable certain extensions even if the host cpu sports them.
src/detect/mod.rs
RUST_STD_DETECT_DISABLE
env::var
check@gnzlbg Do you see any problem in this approach?
The text was updated successfully, but these errors were encountered: