Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from doc(include) to doc = include_str! #1013

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Feb 25, 2021

I plan to deprecate doc(include) in the near future, and rust-lang/rust denies warnings in CI.

cc rust-lang/rust#78835 (comment), rust-lang/rust#44732 (comment)

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@jyn514
Copy link
Member Author

jyn514 commented Feb 25, 2021

The test failure looks unrelated.

failures:

---- core_arch::x86::sse2::tests::test_mm_storeu_pd stdout ----
thread 'core_arch::x86::sse2::tests::test_mm_storeu_pd' panicked at 'assertion failed: `(left == right)`
  left: `0.0`,
 right: `1.0`', crates/core_arch/src/x86/sse2.rs:4747:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Amanieu
Copy link
Member

Amanieu commented Feb 25, 2021

CI should be fixed by #1015, try rebasing.

I plan to deprecate `doc(include)` in the near future, and
rust-lang/rust denies warnings in CI.
@jyn514
Copy link
Member Author

jyn514 commented Feb 25, 2021

Thanks, done.

@Amanieu Amanieu merged commit 77e5b51 into rust-lang:master Feb 26, 2021
@jyn514 jyn514 deleted the doc-include branch February 26, 2021 00:46
najamelan added a commit to najamelan/async_executors that referenced this pull request Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants