Clean up examples, make it more "Rusty" #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Sep 28, 2024
examples/connect5.rs
Outdated
| @@ -651,10 +636,8 @@ fn eval(pos: &Pos, _ply: i32) -> i32 { | |||
| return 2560; | |||
| } | |||
| } | |||
| } else { | |||
| if check_patterndead4(pos, atk) > 0 { | |||
There was a problem hiding this comment.
I'm not a fan of this clippy lint, I think in many cases it actually makes the code less readable.
There was a problem hiding this comment.
@Amanieu which clippy lint are you not a fan of? Most of these are simple stylistic changes that are pretty standard in the Rust code... to my knowledge
There was a problem hiding this comment.
Specifically the one that turns else { if X {} } into else if X {}. I often find that the additional nesting improves readability, especially if the X condition is completely unrelated to the condition in the outer if.
There was a problem hiding this comment.
Could you undo the change to else here and above?
nyurik
force-pushed
the
examples
branch
3 times, most recently
from
f233e0a
to
9c5e92b
Compare
|
thx, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.