Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more things that do adds #881

Merged
merged 11 commits into from
Aug 9, 2020
Merged

add more things that do adds #881

merged 11 commits into from
Aug 9, 2020

Conversation

Lokathor
Copy link
Contributor

@Lokathor Lokathor commented Aug 8, 2020

I'm doing this on an arm32 device so I've already run all those tests and squared that away, but for arm64 we'll have to rely on the CI.

  • The last two "add"
  • "add across vector" (aka horizontal add)
  • "add pairwise"

@Lokathor
Copy link
Contributor Author

Lokathor commented Aug 8, 2020

Alright, the current batch of errors should be fixed, except for the vek_leak feature no longer being needed.

I assume that we just delete that line now that it's stable, but I'll wait to let someone else confirm that.

@Amanieu
Copy link
Member

Amanieu commented Aug 8, 2020

Yes, you can just delete the vec_leak feature.

@Lokathor
Copy link
Contributor Author

Lokathor commented Aug 8, 2020

Out of time to work on the PR this morning, I will be back later today. If you could diagnose the ICE in the wasi build @Amanieu that would be quite helpful. I think it's just a flutter in the current nightly because this PR doesn't touch any wasi stuff.

@Amanieu
Copy link
Member

Amanieu commented Aug 8, 2020

cc @alexcrichton for the WASI CI failure

@alexcrichton
Copy link
Member

Oh dear looks like something in rustc changed, feel free to drop it and I will investigate next monday

@alexcrichton
Copy link
Member

I've fixed the wasi issue at rust-lang/rust#75316, and I'll circle back here to re-enable CI after that lands.

Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
@Amanieu Amanieu merged commit ac684c4 into rust-lang:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants