-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more things that do adds #881
Conversation
Alright, the current batch of errors should be fixed, except for the I assume that we just delete that line now that it's stable, but I'll wait to let someone else confirm that. |
Yes, you can just delete the |
Out of time to work on the PR this morning, I will be back later today. If you could diagnose the ICE in the wasi build @Amanieu that would be quite helpful. I think it's just a flutter in the current nightly because this PR doesn't touch any wasi stuff. |
cc @alexcrichton for the WASI CI failure |
Oh dear looks like something in rustc changed, feel free to drop it and I will investigate next monday |
I've fixed the wasi issue at rust-lang/rust#75316, and I'll circle back here to re-enable CI after that lands. |
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
I'm doing this on an arm32 device so I've already run all those tests and squared that away, but for arm64 we'll have to rely on the CI.