Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jyn514 and Manishearth to the rustdoc team #384

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

GuillaumeGomez
Copy link
Member

  • @jyn514 has been contributing a lot (even more recently) on rustdoc since they started working on docs.rs.
  • @Manishearth has been contributing to rustdoc for years, the list of their contributions is already quite huge.

I think they will both bring a lot more of new things into rustdoc.

Do you approve their integrations @rust-lang/rustdoc?

@jyn514
Copy link
Member

jyn514 commented Jul 17, 2020

ERROR validation error: user `jyn514` has the permission `bors.rust.try` both explicitly and through the `rustdoc` team

Oops, you probably need to update people/jyn514.toml.

@kinnison
Copy link
Contributor

👍 from me

@Mark-Simulacrum
Copy link
Member

I think we should also move the perf = true from @jyn514 to the rustdoc team as a whole, now that perf supports doc benchmarking it makes sense to integrate that I think.

@GuillaumeGomez
Copy link
Member Author

@Mark-Simulacrum Good idea! Should I open another PR for that?

@Mark-Simulacrum
Copy link
Member

Up to you. Happy to have it happen in this PR too (maybe as a separate commit).

@GuillaumeGomez
Copy link
Member Author

Done!

@Mark-Simulacrum
Copy link
Member

Okay I think we'll want approval from @ollie27 presumably and then this is good to go.

@GuillaumeGomez
Copy link
Member Author

Absolutely. :)

@ollie27
Copy link
Member

ollie27 commented Jul 17, 2020

Fine with me 👍

@GuillaumeGomez
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants