Add ability to ping WGs members using triagebot

[spastorino]

We've agreed on Zulip that is going to be great if we can have a way of pinging WG members (which are not part of rust-lang github org) using triagebot.

People is already able to sign up by themselves to WGs, just by sending a PR to the team repo on github. We would stick with that idea and encourage people to do so.

This issue is about being able to reach them out. We want a command like @rustbot icebreaker llvm that would add a github comment reaching out all the members of that working group with a text that looks like ...

Hey LLVM icebreakers! This bug has been identified as a good
"LLVM ice-breaking candidate". In case it's useful, here are some
[general instructions](link) for tackling these sorts of bugs. Maybe take a look?

cc @foo @bar @baz ...

Where, the first part of that text is a predefined text that's specific to the working group. Every working group has a very similar text but it's not exactly the same. Specifically the link to instructions is going to be different.

And then, in the cc part, the bot figures out the list of members it needs to mention.

[Mark-Simulacrum]

Ideally (from an implementation perspective) the command here would be something like @rustbot ping wg-llvm-icebreakers I think? We basically want to match the naming in the team repo instead of creating arbitrary maps I think...

[pietroalbini]

Where, the first part of that text is a predefined text that's specific to the working group. Every working group has a very similar text but it's not exactly the same. Specifically the link to instructions is going to be different.

Where would you like that to be configured? The team repo or the triagebot.toml at the root of the rustc repo?

[nikomatsakis]

I think the command "ping" seems fine.

I think the team repo seems best, in terms of where this should be documented.

I'm not sure if this should be classified as a working group or not. We use that term for a lot of things right now (I think too many, partly my fault) and this feels distinct from other uses of the term. I'm reluctant to add another. That said, I'm not sure what else to call it. =) I mean maybe we just call it ICE-breaker-llvm? In terms of the file hierarchy, we could just have "icebreaker-llvm.toml"?

If we were to list them on the web page (which we don't necessarily have to do), we'd list them as "LLVM ICE breakers" with a link to the page about what this means?

Also, I think the command text could probably be the same for all the "ICE-breaker" groups, but the link would vary. So we could hard-code most of the text and just configure the link.

One final thing: the command should also apply the ICEBreaker-LLVM label.

[pietroalbini]

I mean maybe we just call it ICE-breaker-llvm? In terms of the file hierarchy, we could just have "icebreaker-llvm.toml"?

Not really, as that would be considered a team, which would for example include the members in all@.

If we were to list them on the web page (which we don't necessarily have to do), we'd list them as "LLVM ICE breakers" with a link to the page about what this means?

If ICE breakers are in the team repo we can surely list them.

[nikomatsakis]

Not really, as that would be considered a team

I guess we'd have to extend the team repo logic a bit then

[Mark-Simulacrum]

@pietroalbini would probably be the best bet on those team repo changes -- I myself am not super familiar with the code, though could probably figure it out if needed (not sure how much time Pietro has these days).

[pietroalbini]

I'll probably won't have time to work on the team repo side this week.

[spastorino]

With rust-lang/team#135 and rust-lang/team#123 merged. This can now be implemented :)

[Mark-Simulacrum]

@rustbot ping wg-meta

Testing the new functionality out...

[rustbot]

Error: The feature ping is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

[Mark-Simulacrum]

@rustbot ping wg-meta

And now...

[rustbot]

Error: The feature ping is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

[Mark-Simulacrum]

@rustbot ping wg-meta

[rustbot]

Error: The feature ping is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please let @rust-lang/release know if you're having trouble with this bot.

[Mark-Simulacrum]

@rustbot ping wg-meta

[rustbot]

This is just testing some functionality, please ignore this ping.

cc @davidtwco @nikomatsakis @spastorino

[Mark-Simulacrum]

Okay so that looks like exactly what we wanted, I believe.

The configuration for the above ping can be seen in this repository: https://github.com/rust-lang/triagebot/blob/master/triagebot.toml

I'll re-deploy triagebot's server shortly so that the changes are live for all repositories and can be used on rust-lang/rust for example. We don't currently try to detect >50 users in the team so that'll be a potential problem, but not really one we can easily avoid, so I wouldn't worry too much about it just yet. One solution might be to have triagebot send an email directly instead of a GH notification or just split into two comments...

[Mark-Simulacrum]

Closing as we've added this functionality... we'll want a PR to rust-lang/rust to add the config there but that should be a matter for y'all not this repo :)

[nikomatsakis]

@Mark-Simulacrum one question btw -- can anybody do pings? Do we want some sort of access control? I guess we can conceivably wait until we have a problem... but I think it'd make sense to require "triage" access or something similar.

[nikomatsakis]

Also, I documented this feature in the wiki here https://github.com/rust-lang/triagebot/wiki/Pinging

[Mark-Simulacrum]

Right now we allow anyone to do so since but I can easily constrain down to essentially all@ (teams + WGs). Seems reasonable to do that.