-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icebreakers-llvm team #123
Add icebreakers-llvm team #123
Conversation
So, the way I'd go to exclude them from You'll need to add a new field to the schema and use it to tweak how team members are collected. A validation rule to prevent Just find a better name for |
1749a8f
to
d51af31
Compare
@pietroalbini I've added some code, check it out and let me know if I'm lacking some stuff. In particular as I've commented I've added a feature flag to allow non exhaustive match for the enum we talked about but I guess that's not acceptable for this repo. |
d51af31
to
11785b6
Compare
11785b6
to
6b9955c
Compare
So this PR is back to just adding the team, the infra work is done in #135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a marker-team
.
6b9955c
to
f4282c6
Compare
f4282c6
to
7f756b2
Compare
Integrations to update:
Note: the changes will need to be deployed before the checkboxes can be ticked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine on the technical side for me.
r? @nikomatsakis for merging the changes?
We've discussed on Zulip about adding icebreakers-llvm as a team with minimal everything (no github, no website) as can be seen on the toml file, instead of doing this as a working group.
From what we've quickly seen on team repo by doing what I've done in the PR this group would end included in
all@
. What would be the best way to avoid that?./cc @nikomatsakis @pietroalbini @Mark-Simulacrum (this is also related to rust-lang/triagebot#169)