Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icebreakers-llvm team #123

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

spastorino
Copy link
Member

We've discussed on Zulip about adding icebreakers-llvm as a team with minimal everything (no github, no website) as can be seen on the toml file, instead of doing this as a working group.

From what we've quickly seen on team repo by doing what I've done in the PR this group would end included in all@. What would be the best way to avoid that?.

/cc @nikomatsakis @pietroalbini @Mark-Simulacrum (this is also related to rust-lang/triagebot#169)

@pietroalbini
Copy link
Member

So, the way I'd go to exclude them from all@ would be to create another state similar to wg = true. Bikeshedding is really welcome, maybe we should go with something like marker-team = true (I hate that name btw)?

You'll need to add a new field to the schema and use it to tweak how team members are collected. A validation rule to prevent wg = true with marker-team = true would also be nice. The most annoying part of this will be to expose the new state in the API. Unfortunately it's an enum at the moment and I'm pretty sure some integrations are exaustively matching it (at least the website does). You'll need to audit them to make sure they won't break, and ideally add a __NonExaustive to prevent this issue from happening in the future.

Just find a better name for marker-team = true please 😛

@spastorino
Copy link
Member Author

spastorino commented Oct 3, 2019

@pietroalbini I've added some code, check it out and let me know if I'm lacking some stuff. In particular as I've commented I've added a feature flag to allow non exhaustive match for the enum we talked about but I guess that's not acceptable for this repo.

@spastorino spastorino closed this Oct 3, 2019
@spastorino spastorino reopened this Oct 3, 2019
rust_team_data/src/lib.rs Outdated Show resolved Hide resolved
@spastorino
Copy link
Member Author

spastorino commented Oct 3, 2019

So this PR is back to just adding the team, the infra work is done in #135

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a marker-team.

@pietroalbini
Copy link
Member

pietroalbini commented Oct 7, 2019

Integrations to update:

Note: the changes will need to be deployed before the checkboxes can be ticked.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on the technical side for me.

r? @nikomatsakis for merging the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants