-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tools): Add a link to the Helix editor #1697
Conversation
cc @pietroalbini thoughts? in general the intent of this has kinda been to be well known editors but perhaps this section needs to be restructured, there are a LOT more editors with rust support than there were at the time of this page's writing. Unsure what we should be doing here. Also the intent of this has not been to advertise editors, but rather to get people links to how they can make $language work with their editor. As such I'm not sure if we need to mention editors with builtin support (or perhaps we should mention it in a different way?) |
Thank you for your quick feedback! Maybe it could be worth considering an approach like editorconfig.org, which differentiates between editors with native support and editors which require a plugin. However, both groups of editors are shown. I think that approach would have two advantages:
To summarize, I believe the question boils down to what kind of information we want to present to the visitor:
|
I recommend using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @usagi-flow, I would like to merge this.
- There is a free spot in the 2x4 grid, adding helix will make it look nice.
- According to the most recent Rust survey, helix is actually quite popular among Rust devs (8.9%).
- It's true that the purpose of the whole List is becoming more questionable as Rust is quite mature and established at this point. But I think that question can / should be resolved separately.
The order seems a little random to me at the moment, but I might sort them all according to popularity in a different PR.
I know it's been a while. Would you like to get it over the finish line or do you want me to take over?
Thank you @senekor for taking this PR into consideration! If that's OK, I'll have a look at it tomorrow and rebase the branch accordingly. |
30959c3
to
6e5788a
Compare
@senekor Sorry for letting you wait, but here's the rebased branch with the adjusted link! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #1696